chore: modernize RakNet to current C++ and CMake standards#1
Draft
chore: modernize RakNet to current C++ and CMake standards#1
Conversation
…, remove register keyword Agent-Logs-Url: https://github.com/Avedith/RakNet/sessions/d2ab6864-5686-4714-806d-84523179c438 Co-authored-by: Avedith <65852834+Avedith@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Avedith
April 30, 2026 02:51
View session
…erflow Agent-Logs-Url: https://github.com/Avedith/RakNet/sessions/9ba542fa-ed0e-4298-8ec1-587c8134e2ce Co-authored-by: Avedith <65852834+Avedith@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
counter != position(unsigned) instead ofcounter > position; ifposition > list_sizein a release build (assert only fires in_DEBUG) the loop never terminates and corrupts memorymemcpy(sharedString->c_str, bytes, count+1)reads one byte past the caller's input buffer and can overflow the internalsmallStringbuffer whencount == smallStringSize; fix: copy onlycountbytes (null terminator is set on the next line)strcpy(hostAddress, _hostAddress)has no length guard;hostAddressis only 32 bytes, an IPv6 address literal longer than 31 chars overflows it; fix: usestrncpywith explicit null-termination